linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Simplify determination of serial clock on/off state from votes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CE71EC88-E49F-4EA6-AB19-7DED9E0A8E0B@holtmann.org>
Date:   Mon, 8 Jun 2020 10:09:46 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-kernel@...r.kernel.org,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        linux-bluetooth@...r.kernel.org,
        Rocky Liao <rjliao@...eaurora.org>,
        Zijun Hu <zijuhu@...eaurora.org>,
        Balakrishna Godavarthi <bgodavar@...eaurora.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Simplify determination of serial
 clock on/off state from votes

Hi Matthias,

> The serial clocks should be on when there is a vote for at least one
> of the clocks (RX or TX), and off when there is no 'on' vote. The
> current logic to determine the combined state is a bit redundant
> in the code paths for different types of votes, use a single
> statement in the common path instead.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> 
> drivers/bluetooth/hci_qca.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel