linux-kernel - Re: [PATCH 3/3] Bluetooth: hci_qca: Refactor error handling in qca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7C70D49B-16CE-4299-8E35-78FA0668FF65@holtmann.org>
Date:   Mon, 8 Jun 2020 10:14:54 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org,
        Rocky Liao <rjliao@...eaurora.org>,
        Zijun Hu <zijuhu@...eaurora.org>, linux-kernel@...r.kernel.org,
        Balakrishna Godavarthi <bgodavar@...eaurora.org>,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        Claire Chang <tientzu@...omium.org>
Subject: Re: [PATCH 3/3] Bluetooth: hci_qca: Refactor error handling in
 qca_suspend()

Hi Matthias,

> If waiting for IBS sleep times out jump to the error handler, this is
> easier to read than multiple 'if' branches and a fall through to the
> error handler.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> 
> drivers/bluetooth/hci_qca.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel