linux-kernel - RE: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR0502MB382638933BF9B7BE0AB34E81D7850@AM0PR0502MB3826.eurprd05.prod.outlook.com>
Date:   Mon, 8 Jun 2020 10:02:04 +0000
From:   Amit Cohen <amitc@...lanox.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "corbet@....net" <corbet@....net>, Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>,
        "cforno12@...ux.vnet.ibm.com" <cforno12@...ux.vnet.ibm.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "linux@...pel-privat.de" <linux@...pel-privat.de>,
        "alexandru.ardelean@...log.com" <alexandru.ardelean@...log.com>,
        Aya Levin <ayal@...lanox.com>,
        Petr Machata <petrm@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        "liuhangbin@...il.com" <liuhangbin@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: RE: [RFC PATCH net-next 05/10] Documentation: networking:
 ethtool-netlink: Add link extended state

Andrew Lunn <andrew@...n.ch> writes:

>> +Link extended states:
>> +
>> +  ============================    =============================================
>> +  ``Autoneg failure``             Failure during auto negotiation mechanism
>
>I think you need to define 'failure' here.
>
>Linux PHYs don't have this state. auto-neg is either ongoing, or has completed. There is no time limit for auto-neg. If there is no link partner, auto-neg does not fail, it just continues until there is a link partner which responds and negotiation completes.
>
>Looking at the state diagrams in 802.3 clause 28, what do you consider as failure?
>

Ok, you're right. What about renaming this state to "Autoneg issue" and then as ext_substate you can use something like "Autoneg ongoing"? 

>	 Andrew