[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+V-a8vOErQGkSYtiQ=8QLg+0WRyDZ1dHWfuxm6P2E-gAiirzA@mail.gmail.com>
Date: Mon, 8 Jun 2020 15:50:56 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/11] arm64: dts: renesas: hihope-common: Separate out
Rev.2.0 specific into hihope-common-rev2.dtsi file
Hi Geert,
Thank you for the review.
On Mon, Jun 8, 2020 at 3:27 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Sun, Jun 7, 2020 at 8:41 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> > Separate out Rev.2.0 specific hardware changes into
> > hihope-common-rev2.dtsi file so that hihope-common.dtsi can be used
> > by all the variants for RZ/G2M[N] boards.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@...renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common-rev2.dtsi
> > @@ -0,0 +1,101 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree Source for the HiHope RZ/G2[MN] main board Rev.2.0 common
> > + * parts
> > + *
> > + * Copyright (C) 2020 Renesas Electronics Corp.
> > + */
> > +
> > +#include <dt-bindings/gpio/gpio.h>
>
> What about adding
>
> #include "hihope-common.dtsi"
>
> here?
> Then the *rev2.dts files have to include only "hihope-common-rev2.dtsi",
> and get "hihope-common.dtsi" for free?
>
> The same is true for the rev4.dtsi and the rev4.dts files.
>
Agreed.
Cheers,
--Prabhakar
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Powered by blists - more mailing lists