linux-kernel - Re: [PATCH] tracing/probe: Fix bpf_task_fd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f92dbbe-3e63-8646-7baf-01480dc5fb6c@fb.com>
Date:   Mon, 8 Jun 2020 08:24:59 -0700
From:   Yonghong Song <yhs@...com>
To:     Jean-Philippe Brucker <jean-philippe@...aro.org>,
        <linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
CC:     <mhiramat@...nel.org>, <rostedt@...dmis.org>, <mingo@...hat.com>,
        <ast@...nel.org>, <daniel@...earbox.net>, <kafai@...com>,
        <songliubraving@...com>, <andriin@...com>,
        <john.fastabend@...il.com>, <kpsingh@...omium.org>
Subject: Re: [PATCH] tracing/probe: Fix bpf_task_fd_query() for kprobes and
 uprobes


On 6/8/20 5:45 AM, Jean-Philippe Brucker wrote:
> Commit 60d53e2c3b75 ("tracing/probe: Split trace_event related data from
> trace_probe") removed the trace_[ku]probe structure from the
> trace_event_call->data pointer. As bpf_get_[ku]probe_info() were
> forgotten in that change, fix them now. These functions are currently
> only used by the bpf_task_fd_query() syscall handler to collect
> information about a perf event.
>
> Fixes: 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@...aro.org>

Thanks for the fix.

Acked-by: Yonghong Song <yhs@...com>


> ---
> Found while trying to run the task_fd_query BPF sample. I intend to try
> and move that sample to kselftests since it seems like a useful
> regression test.

That will be great. Thanks!