linux-kernel - [PATCH v6 0/8] block: fix blktrace debugfs use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  8 Jun 2020 17:01:20 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     axboe@...nel.dk, viro@...iv.linux.org.uk, bvanassche@....org,
        gregkh@...uxfoundation.org, rostedt@...dmis.org, mingo@...hat.com,
        jack@...e.cz, ming.lei@...hat.com, nstange@...e.de,
        akpm@...ux-foundation.org
Cc:     mhocko@...e.com, yukuai3@...wei.com, martin.petersen@...cle.com,
        jejb@...ux.ibm.com, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>
Subject: [PATCH v6 0/8] block: fix blktrace debugfs use after free

Here is v6 of the blktrace fixes which address the debugfs use after
free. I've followed the strategy suggested by Christoph of open coding
the solution in place, and extended it with the required work for
partitions and scsi-generic. Jan's blktrace sparse fix ended up
depending on one of my patch, "blktrace: break out of blktrace setup
on concurrent calls", and so he has sent those for inclusion prior to my
series. This series would have to be applied after those two patches
from Jan are merged then.

Since the patch "blktrace: fix debugfs use after free" ends up being the
only one modified lately, I've moved that patch to be the last one in
the series now.

You can find these on my git tree branch 20200608-blktrace-fixes based
on linux-next 20200608 [0].

Hopefully this is it.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200608-blktrace-fixes

Luis Chamberlain (6):
  block: add docs for gendisk / request_queue refcount helpers
  block: clarify context for refcount increment helpers
  block: revert back to synchronous request_queue removal
  blktrace: annotate required lock on do_blk_trace_setup()
  loop: be paranoid on exit and prevent new additions / removals
  blktrace: fix debugfs use after free

 block/blk-core.c             | 27 ++++++++++--
 block/blk-mq-debugfs.c       |  5 ---
 block/blk-sysfs.c            | 83 +++++++++++++++++++++++++++---------
 block/blk.h                  |  2 -
 block/genhd.c                | 73 ++++++++++++++++++++++++++++++-
 block/partitions/core.c      |  3 ++
 drivers/block/loop.c         |  4 ++
 drivers/scsi/sg.c            |  3 ++
 include/linux/blkdev.h       |  6 +--
 include/linux/blktrace_api.h |  1 -
 include/linux/genhd.h        |  1 +
 kernel/trace/blktrace.c      | 55 ++++++++++++++++++------
 12 files changed, 214 insertions(+), 49 deletions(-)

-- 
2.26.2