linux-kernel - Re: [PATCH 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200609112157.GC4583@sirena.org.uk>
Date:   Tue, 9 Jun 2020 12:21:57 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Pi-Hsun Shih <pihsun@...omium.org>
Cc:     Nicolas Boichat <drinkcat@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        "open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" 
        <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add DT binding for
 cros-ec-regulator

On Tue, Jun 09, 2020 at 03:59:54PM +0800, Pi-Hsun Shih wrote:

> +  google,remote-regulator:
> +    description: Identifier for the voltage regulator to ChromeOS EC.
> +    $ref: "/schemas/types.yaml#/definitions/uint32"

As I said in reviewing the patch this is a bit weird - it feels like it
should be a reg property on a bus rather than a property like this.  How
exactly to these devices get created - can the core device for the EC
enumerate the regulators that are present?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)