linux-kernel - Re: [PATCH v6 00/12] Add a new mmap locking API wrapping mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Jun 2020 14:03:28 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Michel Lespinasse <walken@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Matthew Wilcox <willy@...radead.org>,
        Liam Howlett <Liam.Howlett@...cle.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        David Rientjes <rientjes@...gle.com>,
        Hugh Dickins <hughd@...gle.com>, Ying Han <yinghan@...gle.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v6 00/12] Add a new mmap locking API wrapping mmap_sem
 calls

Hi,

On Tue 19-05-20 22:28:56, Michel Lespinasse wrote:
> Reposting this patch series on top of v5.7-rc6. I think this is ready
> for inclusion into the -mm tree; however there were some minor points
> of feedback to address and also it was easier to regenerate a full
> version after the v5.5 (only updating patches 09/10 and 10/10) caused
> some confusion.
> 
> 
> This patch series adds a new mmap locking API replacing the existing
> mmap_sem lock and unlocks. Initially the API is just implemente in terms
> of inlined rwsem calls, so it doesn't provide any new functionality.
> 
> There are two justifications for the new API:
> 
> - At first, it provides an easy hooking point to instrument mmap_sem
>   locking latencies independently of any other rwsems.
> 
> - In the future, it may be a starting point for replacing the rwsem
>   implementation with a different one, such as range locks. This is
>   something that is being explored, even though there is no wide concensus
>   about this possible direction yet.
>   (see https://patchwork.kernel.org/cover/11401483/)

Sorry that I am jumping late to the game.

Even though I hoped that the new API would somehow start using a
concept of address ranges, because I believe this is a fundamental lock
granularity for this mmap_sem, this is definitely a step in the right
direction. Getting rid of all direct usage of mmap_sem is an
improvement in itself.

Feel free to add
Acked-by: Michal Hocko <mhocko@...e.com>

Thanks!
-- 
Michal Hocko
SUSE Labs