linux-kernel - Re: [PATCH] Input: joystick - work around "adi" module name confict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb9b55d1-152e-a3c7-2804-d7558cc3a995@roeck-us.net>
Date:   Tue, 9 Jun 2020 06:52:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...db.de>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-input@...r.kernel.org, Markus Koch <markus@...syncing.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: joystick - work around "adi" module name confict

On 6/9/20 3:06 AM, Arnd Bergmann wrote:
> Making module name conflicts a fatal error breaks sparc64
> allmodconfig:
> 
> Error log:
> error: the following would cause module name conflict:
>   drivers/char/adi.ko
>   drivers/input/joystick/adi.ko
> 
> Renaming one of the modules would solve the problem, but then cause other
> problems because neither of them is automatically loaded and changing
> the name is likely to break any setup that relies on manually loading
> it by name.
> 
> As there is probably no sparc64 system with this kind of ancient joystick
> attached, work around it by adding a Kconfig dependency that forbids
> them from both being modules.  It is still possible to build the joystick
> driver if the sparc64 adi driver is built-in.
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> This should get merged through the kbuild tree together
> with the patch that turns the warning into an error, if the
> joystick maintainers are ok with the hack.
> ---
>  drivers/input/joystick/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
> index 940b744639c7..6f73f02059b5 100644
> --- a/drivers/input/joystick/Kconfig
> +++ b/drivers/input/joystick/Kconfig
> @@ -45,6 +45,7 @@ config JOYSTICK_A3D
>  config JOYSTICK_ADI
>  	tristate "Logitech ADI digital joysticks and gamepads"
>  	select GAMEPORT
> +	depends on ADI!=m # avoid module name conflict
>  	help
>  	  Say Y here if you have a Logitech controller using the ADI
>  	  protocol over the PC gameport.
>