linux-kernel - Re: [PATCH v1] lib/bitmap: Convert infinite while loop to for one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200609142316.GA7558@oc3871087118.ibm.com>
Date:   Tue, 9 Jun 2020 16:23:16 +0200
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, yury.norov@...il.com
Subject: Re: [PATCH v1] lib/bitmap: Convert infinite while loop to for one

On Tue, Jun 09, 2020 at 05:05:35PM +0300, Andy Shevchenko wrote:
> Convert infinite while loop to for one in order to be more explicit
> in one place what we are doing with chunks.

Reviewed-by: Alexander Gordeev <agordeev@...ux.ibm.com>

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> 
> Andrew, this can be folded to the fix
> 
>  lib/bitmap.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index 10f8fa0497e3..03ef42fbe658 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -740,10 +740,10 @@ int bitmap_parse(const char *start, unsigned int buflen,
>  	const char *end = strnchrnul(start, buflen, '\n') - 1;
>  	int chunks = BITS_TO_U32(nmaskbits);
>  	u32 *bitmap = (u32 *)maskp;
> -	int chunk = 0;
>  	int unset_bit;
> +	int chunk;
>  
> -	while (1) {
> +	for (chunk = 0; ; chunk++) {
>  		end = bitmap_find_region_reverse(start, end);
>  		if (start > end)
>  			break;
> @@ -758,7 +758,6 @@ int bitmap_parse(const char *start, unsigned int buflen,
>  #endif
>  		if (IS_ERR(end))
>  			return PTR_ERR(end);
> -		chunk++;
>  	}
>  
>  	unset_bit = (BITS_TO_U32(nmaskbits) - chunks) * 32;
> -- 
> 2.27.0.rc2
>