linux-kernel - Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Jun 2020 16:29:59 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     Jacopo Mondi <jacopo@...ndi.org>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        <kieran.bingham+renesas@...asonboard.com>, <geert@...ux-m68k.org>,
        <horms@...ge.net.au>, <uli+renesas@...nd.eu>,
        <VenkataRajesh.Kalakodima@...bosch.com>, <airlied@...ux.ie>,
        <daniel@...ll.ch>, <koji.matsuoka.xm@...esas.com>,
        <muroya@....co.jp>, <Harsha.ManjulaMallikarjun@...bosch.com>,
        <ezequiel@...labora.com>, <seanpaul@...omium.org>,
        <linux-renesas-soc@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <michael.dege@...esas.com>, <gotthard.voellmeke@...esas.com>,
        <efriedrich@...adit-jv.com>, <mrodin@...adit-jv.com>,
        <ChaitanyaKumar.Borah@...bosch.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>
Subject: Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

Hi Laurent,

On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote:
> Note that the CMM driver is controlled by the DU driver. As the DU
> driver will reenable the display during resume, it will call
> rcar_du_cmm_setup() at resume time, which will reprogram the CMM. There
> should thus be no need for manual suspend/resume handling in the CMM as
> far as I can tell, but we need to ensure that the CMM is suspended
> before and resumed after the DU. I believe this could be implemented
> using device links.

Based on below quote [*] from Jacopo's commit [**], isn't the device
link relationship already in place?

[*] Quote from commit [**]
   Enforce the probe and suspend/resume ordering of DU and CMM by
   creating a stateless device link between the two.

[**] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8de707aeb45241
    ("drm: rcar-du: kms: Initialize CMM instances")

-- 
Best regards,
Eugeniu Rosca