linux-kernel - Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1ef3b6c-edc5-b190-5ce6-e446cf73ccc8@gmail.com>
Date:   Tue, 9 Jun 2020 17:33:45 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>,
        Roman Gushchin <guro@...com>
Cc:     "catalin.marinas@....com" <catalin.marinas@....com>,
        John Garry <john.garry@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "Zengtao (B)" <prime.zeng@...ilicon.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "hch@....de" <hch@....de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>
Subject: Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init



On 08/06/2020 02:50, Song Bao Hua (Barry Song) wrote:
> 
> 
>> -----Original Message-----
>> From: Matthias Brugger [mailto:matthias.bgg@...il.com]
>> Sent: Monday, June 8, 2020 8:15 AM
>> To: Roman Gushchin <guro@...com>; Song Bao Hua (Barry Song)
>> <song.bao.hua@...ilicon.com>
>> Cc: catalin.marinas@....com; John Garry <john.garry@...wei.com>;
>> linux-kernel@...r.kernel.org; Linuxarm <linuxarm@...wei.com>;
>> iommu@...ts.linux-foundation.org; Zengtao (B) <prime.zeng@...ilicon.com>;
>> Jonathan Cameron <jonathan.cameron@...wei.com>;
>> robin.murphy@....com; hch@....de; linux-arm-kernel@...ts.infradead.org;
>> m.szyprowski@...sung.com
>> Subject: Re: [PATCH 2/3] arm64: mm: reserve hugetlb CMA after numa_init
>>
>>
>>
>> On 03/06/2020 05:22, Roman Gushchin wrote:
>>> On Wed, Jun 03, 2020 at 02:42:30PM +1200, Barry Song wrote:
>>>> hugetlb_cma_reserve() is called at the wrong place. numa_init has not been
>>>> done yet. so all reserved memory will be located at node0.
>>>>
>>>> Cc: Roman Gushchin <guro@...com>
>>>> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
>>>
>>> Acked-by: Roman Gushchin <guro@...com>
>>>
>>
>> When did this break or was it broken since the beginning?
>> In any case, could you provide a "Fixes" tag for it, so that it can easily be
>> backported to older releases.
> 
> I guess it was broken at the first beginning.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cf11e85fc08cc
> 
> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
> 
> Would you think it is better for me to send v2 for this patch separately with this tag and take this out of my original patch set for per-numa CMA?
> Please give your suggestion.
> 

I'm not the maintainer but I think it could help to get the patch accepted
earlier while you address the rest of the series.

Regards,
Matthias