linux-kernel - Re: [PATCH] sysctl: Delete the code of sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006090839.6EDB4BA@keescook>
Date:   Tue, 9 Jun 2020 08:40:36 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     ebiederm@...ssion.com, ak@...ux.intel.com,
        alex.huangjianhui@...wei.com, linzichang@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysctl: Delete the code of sys_sysctl

On Tue, Jun 09, 2020 at 02:20:05PM +0800, Xiaoming Ni wrote:
> Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"),
> sys_sysctl has lost its actual role: any input can only return an error.
> 
> Delete the code and return -ENOSYS directly at the function entry
> 
> Signed-off-by: Xiaoming Ni <nixiaoming@...wei.com>

Looks right to me.

Reviewed-by: Kees Cook <keescook@...omium.org>

Should this be taken a step further and just remove the syscall entirely
and update the per-arch tables with the ENOSYS hole?

-Kees

-- 
Kees Cook