linux-kernel - Re: [PATCH] mm: Move p?d_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200610015327.02d210ba@canb.auug.org.au>
Date:   Wed, 10 Jun 2020 01:53:27 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Joerg Roedel <joro@...tes.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-arch@...r.kernel.org, jroedel@...e.de, linux-mm@...ck.org,
        peterz@...radead.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linuxppc-dev@...ts.ozlabs.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Abdul Haleem <abdhalee@...ux.vnet.ibm.com>,
        linux-next@...r.kernel.org,
        Satheesh Rajendran <sathnaga@...ux.vnet.ibm.com>,
        Andy Lutomirski <luto@...nel.org>, manvanth@...ux.vnet.ibm.com,
        hch@....de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file

Hi Christophe,

On Tue, 9 Jun 2020 17:24:14 +0200 Christophe Leroy <christophe.leroy@...roup.eu> wrote:
>
> Le 09/06/2020 à 14:05, Joerg Roedel a écrit :
> > From: Joerg Roedel <jroedel@...e.de>
> > 
> > The functions are only used in two source files, so there is no need
> > for them to be in the global <linux/mm.h> header. Move them to the new
> > <linux/pgalloc-track.h> header and include it only where needed.  
> 
> Do you mean we will now create a new header file for any new couple on 
> functions based on where they are used ?
> 
> Can you explain why this change is needed or is a plus ?

Well at a minimum, it means 45 lines less to be parsed every time the
linux/mm is included (in at last count, 1996 places some of which are
include files included by other files).  And, as someone who does a lot
of builds every day, I am in favour of that :-)

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped