linux-kernel - RE: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Jun 2020 19:51:43 +0000
From:   Leo Li <leoyang.li@....com>
To:     Hui Song <hui.song_1@....com>,
        "linux-devel@...ux.nxdi.nxp.com" <linux-devel@...ux.nxdi.nxp.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Hui Song <hui.song_1@....com>
Subject: RE: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.



> -----Original Message-----
> From: Hui Song <hui.song_1@....com>
> Sent: Tuesday, June 9, 2020 4:38 AM
> To: linux-devel@...ux.nxdi.nxp.com; Shawn Guo <shawnguo@...nel.org>;
> Leo Li <leoyang.li@....com>; Rob Herring <robh+dt@...nel.org>; Mark
> Rutland <mark.rutland@....com>; Linus Walleij <linus.walleij@...aro.org>;
> Bartosz Golaszewski <bgolaszewski@...libre.com>
> Cc: linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-gpio@...r.kernel.org; Hui Song
> <hui.song_1@....com>
> Subject: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
> 
> From: Song Hui <hui.song_1@....com>
> 
> delete the interrupt IRQF_NO_THREAD flags.

I think this is the correct direction but would be better to describe a little bit on what motived this change.  Any issue encountered or latency optimization?

> 
> Signed-off-by: Song Hui <hui.song_1@....com>
> ---
>  drivers/gpio/gpio-mpc8xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index
> 604dfec..1e86652 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device
> *pdev)
> 
>  	ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
>  			       mpc8xxx_gpio_irq_cascade,
> -			       IRQF_NO_THREAD | IRQF_SHARED, "gpio-
> cascade",
> +			       IRQF_SHARED, "gpio-cascade",
>  			       mpc8xxx_gc);
>  	if (ret) {
>  		dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d),
> ret = %d\n",
> --
> 2.9.5