linux-kernel - Re: [PATCH] dccp: Fix possible memleak in dccp_init and dccp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200609.132736.1760843725831249479.davem@davemloft.net>
Date:   Tue, 09 Jun 2020 13:27:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wanghai38@...wei.com
Cc:     kuba@...nel.org, gerrit@....abdn.ac.uk, posk@...gle.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        dccp@...r.kernel.org
Subject: Re: [PATCH] dccp: Fix possible memleak in dccp_init and dccp_fini

From: Wang Hai <wanghai38@...wei.com>
Date: Tue, 9 Jun 2020 22:18:16 +0800

> There are some memory leaks in dccp_init() and dccp_fini().
> 
> In dccp_fini() and the error handling path in dccp_init(), free lhash2
> is missing. Add inet_hashinfo2_free_mod() to do it.
> 
> If inet_hashinfo2_init_mod() failed in dccp_init(),
> percpu_counter_destroy() should be called to destroy dccp_orphan_count.
> It need to goto out_free_percpu when inet_hashinfo2_init_mod() failed.
> 
> Fixes: c92c81df93df ("net: dccp: fix kernel crash on module load")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>

Applied and queued up for -stable, thank you.