linux-kernel - Re: [PATCH] libbpf: Define _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b2630e7-ac41-b6d4-9e6a-41db717d1b29@iogearbox.net>
Date:   Wed, 10 Jun 2020 01:21:57 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ian Rogers <irogers@...gle.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Pekka Enberg <penberg@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Irina Tirdea <irina.tirdea@...el.com>,
        bpf <bpf@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libbpf: Define __WORDSIZE if not available

On 6/9/20 11:16 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jun 09, 2020 at 10:37:48PM +0200, Daniel Borkmann escreveu:
>> Hey Arnaldo,
>>
>> On 6/9/20 5:34 PM, Arnaldo Carvalho de Melo wrote:
>>> Some systems, such as Android, don't have a define for __WORDSIZE, do it
>>> in terms of __SIZEOF_LONG__, as done in perf since 2012:
>>>
>>>     http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5
>>>
>>> For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
>>>
>>> I build tested it here and Andrii did some Travis CI build tests too.
>>>
>>> Acked-by: Andrii Nakryiko <andriin@...com>
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>>
>> Diff missing?
> 
> Oh well, sorry about that, EBADCOFFEE or something:
> 
> From: Arnaldo Carvalho de Melo <acme@...nel.org>
> 
> Some systems, such as Android, don't have a define for __WORDSIZE, do it
> in terms of __SIZEOF_LONG__, as done in perf since 2012:
> 
>     http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5
> 
> For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
> 
> I build tested it here and Andrii did some Travis CI build tests too.
> 
> Acked-by: Andrii Nakryiko <andriin@...com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
[...]

Applied, thanks!