linux-kernel - Re: Re: [PATCH] media: platform: sti: hva: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2bf52890.fac17.17296b2d470.Coremail.dinghao.liu@zju.edu.cn>
Date:   Tue, 9 Jun 2020 09:30:01 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Hans Verkuil" <hverkuil@...all.nl>
Cc:     kjlu@....edu,
        "Jean-Christophe Trotin" <jean-christophe.trotin@...com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] media: platform: sti: hva: Fix runtime PM imbalance
 on error

Hi Hans,
> err_pm:
>         pm_runtime_put(dev);
> 
> Shouldn't that be pm_runtime_put_sync()?
> 
> I'm not pm expert, but it does look odd.
> 

I checked the implementation of these two APIs before
and found they were exactly the same. So I think it's
fine to keep using pm_runtime_put().

Regards,
Dinghao