linux-kernel - Re: [PATCH 1/1] cxgb4: fix cxgb4_uld_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200608.190737.2279619081686680210.davem@davemloft.net>
Date:   Mon, 08 Jun 2020 19:07:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xypron.glpk@....de
Cc:     vishal@...lsio.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error

From: Heinrich Schuchardt <xypron.glpk@....de>
Date: Mon,  8 Jun 2020 02:58:23 +0200

> When building without CONFIG_CHELSIO_TLS_DEVICE a build error occurs:
> 
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: error:
> ‘cxgb4_uld_in_use’ defined but not used [-Werror=unused-function]
>   666 | static bool cxgb4_uld_in_use(struct adapter *adap)
>       |             ^~~~~~~~~~~~~~~~
> 
> Guard cxgb4_uld_in_use() with #ifdef CONFIG_CHELSIO_TLS_DEVICE.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>


Please see commit ef1c75593e770aff8749e902aa0deb6855a3f485, which already
does this.

Thank you.