linux-kernel - Re: [PATCH] dtc: also check <yaml.h> for libyaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d76f0e39-e22c-7179-955a-981d42b7bc01@windriver.com>
Date:   Tue, 9 Jun 2020 11:07:56 +0800
From:   Jiping Ma <Jiping.Ma2@...driver.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Rob Herring <robh@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        DTML <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dtc: also check <yaml.h> for libyaml



On 06/09/2020 10:52 AM, Masahiro Yamada wrote:
> On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@...driver.com> wrote:
>>
>>
>> On 06/09/2020 03:09 AM, Rob Herring wrote:
>>> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@...driver.com> wrote:
>>>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
>>>> it fails to build.
>>> Does this patch fix your issue?:
>>>
>>> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
>> No, it did not fix the issue.
>>
>> $ pkg-config --cflags yaml-0.1
>>
>> $ pkg-config yaml-0.1 --libs
>> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
>> -lyaml
This issue happened in Yocto,  After completing the SDK build and 
installing it, use a new shell to source the environment and try to 
build the helper scripts.
export 
SDKTARGETSYSROOT=/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux
export 
PKG_CONFIG_PATH=$SDKTARGETSYSROOT/usr/lib64/pkgconfig:$SDKTARGETSYSROOT/usr/share/pkgconfig
>
>
>
> If I install libyaml to a non-standard location
> (/home/masahiro/foo), my pkg-config shows as follows:
>
>
>
> masahiro@...ar:~$ pkg-config --cflags   yaml-0.1
> -I/home/masahiro/foo/include
> masahiro@...ar:~$ pkg-config --libs   yaml-0.1
> -L/home/masahiro/foo/lib -lyaml
>
>
>
>
>
>
>
>>>
>>>> Signed-off-by: Jiping Ma <jiping.ma2@...driver.com>
>>>> ---
>>>>    scripts/dtc/Makefile | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
>>>> index b5a5b1c..b49dfea 100644
>>>> --- a/scripts/dtc/Makefile
>>>> +++ b/scripts/dtc/Makefile
>>>> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
>>>>    endif
>>>>    HOST_EXTRACFLAGS += -DNO_YAML
>>>>    else
>>>> +ifeq ($(wildcard /usr/include/yaml.h),)
>>>> +HOST_EXTRACFLAGS += -DNO_YAML
>>>> +else
>>>>    dtc-objs       += yamltree.o
>>>>    HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
>>>>    endif
>>>> +endif
>>>>
>>>>    # Generated files need one more search path to include headers in source tree
>>>>    HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
>>>> --
>>>> 1.9.1
>>>>
>