linux-kernel - Re: [PATCH v2 0/4] Remove dependency of check subcmd upon orc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2006091143470.13900@pobox.suse.cz>
Date:   Tue, 9 Jun 2020 11:44:11 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Julien Thierry <jthierry@...hat.com>
cc:     linux-kernel@...r.kernel.org, jpoimboe@...hat.com,
        peterz@...radead.org, mhelsley@...are.com
Subject: Re: [PATCH v2 0/4] Remove dependency of check subcmd upon orc

On Mon, 8 Jun 2020, Julien Thierry wrote:

> Hi,
> 
> Matt Helsley's change[1] provided a base framework to opt-in/out
> objtool subcommands at compile time. This makes it easier for
> architectures to port objtool, one subcommand at a time.
> 
> Orc generation relies on the check operation implementation. However,
> the way this is done causes the check implementation to depend on the
> implementation of orc generation functions to call if orc generation is
> requested. This means that in order to implement check subcmd, orc
> subcmd also need to be implemented.
> 
> These patches aim at removing that dependency, having orc subcmd
> being built on top of the check subcmd.
> 
> Changes since v1 [2]:
> - Remove redundant check in create_orc pointed out by Miroslav
> 
> [1] https://www.spinics.net/lists/kernel/msg3510844.html
> [2] https://lkml.org/lkml/2020/6/4/675

Reviewed-by: Miroslav Benes <mbenes@...e.cz>

M