linux-kernel - Re: [PATCH v6 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006091707.I8I2eFef%lkp@intel.com>
Date:   Tue, 9 Jun 2020 17:23:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yifeng Zhao <yifeng.zhao@...k-chips.com>,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        robh+dt@...nel.org
Cc:     kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
        heiko@...ech.de, Yifeng Zhao <yifeng.zhao@...k-chips.com>,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v6 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308,
 RK2928 and others

Hi Yifeng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rockchip/for-next]
[also build test WARNING on robh/for-next linus/master v5.7]
[cannot apply to next-20200608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Yifeng-Zhao/Add-Rockchip-NFC-drivers-for-RK3308-and-others/20200609-155150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/linux/mm.h:95,
from include/linux/scatterlist.h:8,
from include/linux/dma-mapping.h:11,
from drivers/mtd/nand/raw/rockchip-nand-controller.c:10:
include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 |   pte_t old_pte;              |         ^~~~~~~
arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
322 | #define pte_clear(mm, addr, xp)  set_pte_at(mm, addr, xp, __pte(0))
|                                  ^~~~~~~~~~
include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
202 |  pte_clear(mm, address, ptep);
|  ^~~~~~~~~
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 |   pte_t old_pte;              |         ^~~~~~~
include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
641 |  set_pte_at(vma->vm_mm, addr, ptep, pte);
|  ^~~~~~~~~~
drivers/mtd/nand/raw/rockchip-nand-controller.c: At top level:
>> drivers/mtd/nand/raw/rockchip-nand-controller.c:1180:18: warning: initialized field overwritten [-Woverride-init]
1180 |   .bch_st_off  = 0x20,
|                  ^~~~
drivers/mtd/nand/raw/rockchip-nand-controller.c:1180:18: note: (near initialization for 'nfc_v8_cfg.bch_st_off')

vim +1180 drivers/mtd/nand/raw/rockchip-nand-controller.c

  1166	
  1167	static struct nfc_cfg nfc_v8_cfg = {
  1168			.type			= NFC_V8,
  1169			.ecc_strengths		= {16, 16, 16, 16},
  1170			.ecc_cfgs		= {
  1171				0x00000001, 0x00000001, 0x00000001, 0x00000001,
  1172			},
  1173			.flctl_off		= 0x08,
  1174			.bchctl_off		= 0x0C,
  1175			.dma_cfg_off		= 0x10,
  1176			.dma_data_buf_off	= 0x14,
  1177			.dma_oob_buf_off	= 0x18,
  1178			.dma_st_off		= 0x1C,
  1179			.bch_st_off		= 0x20,
> 1180			.bch_st_off		= 0x20,
  1181			.randmz_off		= 0x150,
  1182			.int_en_off		= 0x16C,
  1183			.int_clr_off		= 0x170,
  1184			.int_st_off		= 0x174,
  1185			.oob0_off		= 0x200,
  1186			.oob1_off		= 0x230,
  1187			.ecc0			= {
  1188				.err_flag_bit	= 2,
  1189				.low		= 3,
  1190				.low_mask	= 0x1F,
  1191				.low_bn		= 5,
  1192				.high		= 27,
  1193				.high_mask	= 0x1,
  1194			},
  1195			.ecc1			= {
  1196				.err_flag_bit	= 15,
  1197				.low		= 16,
  1198				.low_mask	= 0x1F,
  1199				.low_bn		= 5,
  1200				.high		= 29,
  1201				.high_mask	= 0x1,
  1202			},
  1203	};
  1204	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61621 bytes)