linux-kernel - Re: [PATCH v2] usb: dwc3: Add support for VBUS power control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200610202255.GA3646369@bogus>
Date:   Wed, 10 Jun 2020 14:22:55 -0600
From:   Rob Herring <robh@...nel.org>
To:     Mike Looijmans <mike.looijmans@...ic.nl>
Cc:     linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        balbi@...nel.org
Subject: Re: [PATCH v2] usb: dwc3: Add support for VBUS power control

On Wed, Jun 03, 2020 at 02:09:15PM +0200, Mike Looijmans wrote:
> Support VBUS power control using regulator framework. Enables the regulator
> while the port is in host mode.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---
> v2: Add missing devm_regulator_get call which got lost during rebase
> 
>  .../devicetree/bindings/usb/dwc3.txt          |  1 +
>  drivers/usb/dwc3/core.c                       | 34 ++++++++++++++-----
>  drivers/usb/dwc3/core.h                       |  4 +++
>  drivers/usb/dwc3/drd.c                        |  6 ++--
>  4 files changed, 33 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 9946ff9ba735..56bc3f238e2d 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -37,6 +37,7 @@ Optional properties:
>   - phys: from the *Generic PHY* bindings
>   - phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy"
>  	or "usb3-phy".
> + - vbus-supply: Regulator handle that provides the VBUS power.

Does the DWC3 block require Vbus to power itself? Doubtful. This 
belongs in a usb-connector node. If the DWC3 driver wants to get the 
Vbus supply, it can fetch it from that node.

Rob