linux-kernel - Re: [PATCH] net: cadence: macb: disable NAPI on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Jun 2020 16:22:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     clabbe@...libre.com
Cc:     antoine.tenart@...tlin.com, linux@...linux.org.uk,
        nicolas.ferre@...rochip.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: cadence: macb: disable NAPI on error

From: Corentin Labbe <clabbe@...libre.com>
Date: Wed, 10 Jun 2020 09:53:44 +0000

> When the PHY is not working, the macb driver crash on a second try to
> setup it.
> [   78.545994] macb e000b000.ethernet eth0: Could not attach PHY (-19)
 ...
> This is due to NAPI left enabled if macb_phylink_connect() fail.
> 
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>

Applied and queued up for v5.5+ -stable, thanks.