linux-kernel - Re: [PATCH v3 4/7] selftests/ftrace: Convert required interface checks into requires list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200610145535.747d2765d60e6e3923441768@kernel.org>
Date:   Wed, 10 Jun 2020 14:55:35 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>
Subject: Re: [PATCH v3 4/7] selftests/ftrace: Convert required interface
 checks into requires list

Hi Shuah,

On Tue, 9 Jun 2020 14:41:27 -0600
Shuah Khan <skhan@...uxfoundation.org> wrote:

> On 6/2/20 8:40 PM, Masami Hiramatsu wrote:
> > Convert the required tracefs interface checking code with
> > requires: list.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> > Reviewed-by: Tom Zanussi <zanussi@...nel.org>
> > ---
> >    Changes in v2: Fix trigger-onchange-action-hist.tc requires list.
> 
> Masami,
> 
> This patch doesn't apply to linux-kselftest next
> 
> Patches 1-3 applied fine and this one failed. For now I will
> hold off on applying this series.

Yes, there is another patch posted by Tom with his ftrace enhancement
in tracing-next. Thus I commented on 0/7 as below.

----
Since this series depends on following 2 commits,

commit 619ee76f5c9f ("selftests/ftrace: Return unsupported if no
 error_log file") on Shuah's Kselftest tree
commit bea24f766efc ("selftests/ftrace: Distinguish between hist
 and synthetic event checks") on Steven's Tracing tree

This can be applied on the tree which merged both of them.
----

I'm not sure how do I handle it. It is OK just modifying this
for linux-kselftest, but in that case we will need another
patch after merged both.

IMHO, since the kselftest must run correctly on older kernel,
(and ftracetest does) Tom's kselftest patch should be merged
into linux-kselftest instead of tracing tree.

Steve, what would you think?

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>