linux-kernel - Re: [PATCH v3 02/15] PCI: Add macro for message signalled interrupt types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200610070828.GA29678@infradead.org>
Date:   Wed, 10 Jun 2020 00:08:28 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Piotr Stankiewicz <piotr.stankiewicz@...el.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        Jonathan Corbet <corbet@....net>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Logan Gunthorpe <logang@...tatee.com>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Zenghui Yu <yuzenghui@...wei.com>,
        Kelsey Skunberg <skunberg.kelsey@...il.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Krzysztof Wilczynski <kw@...ux.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Yicong Yang <yangyicong@...ilicon.com>,
        Denis Efremov <efremov@...ux.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 02/15] PCI: Add macro for message signalled interrupt
 types

On Tue, Jun 09, 2020 at 06:22:40PM +0200, Piotr Stankiewicz wrote:
> There are several places in the kernel which check/ask for MSI or MSI-X
> interrupts. It would make sense to have a macro which defines all types
> of message signalled interrupts, to use in such situations. Add
> PCI_IRQ_MSI_TYPES, for this purpose.

To state my objection voices in patch 3 here again:

I think this is a very bad idea.  Everyone knows what MSI and MSI-X
mean and that directly maps to specification.  The new IMS interrupt
scheme from the Intel SIOV spec for example is a message signalled
interrupt type as well and should not be picked up automatically.

If we want to change anything in this area we should probably remove
PCI_IRQ_ALL_TYPES instead..