linux-kernel - Re: [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6cbb9bb-15df-6283-a509-ea8a8b9bdaab@gmail.com>
Date:   Tue, 9 Jun 2020 18:15:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Álvaro Fernández Rojas <noltari@...il.com>,
        hauke@...ke-m.de, zajec5@...il.com, tsbogend@...ha.franken.de,
        robh+dt@...nel.org, f.fainelli@...il.com, jonas.gorski@...il.com,
        bcm-kernel-feedback-list@...adcom.com, linux-mips@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain
 binding



On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote:
> BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
> to enable/disable certain components in order to save power.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  .../devicetree/bindings/mips/brcm/soc.txt       | 17 +++++++++++++++++

You should probably create a YAML binding from the beginning that way
you get validation for free. This file should ultimately be broken down
into separate YAML bindings, but I Have not had the time to do that yet
(you are welcome to if you feel like it).

Other than that, the binding definition looks good to me.
-- 
Florian