linux-kernel - Re: [PATCH] gpio: rcar: handle pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbS7Vo+uV2LJTQNiqoPHWScDrgQiv=TakL1UFQ=ZGXxiQ@mail.gmail.com>
Date:   Wed, 10 Jun 2020 10:52:27 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Navid Emamdoost <emamd001@....edu>, wu000273@....edu,
        Kangjie Lu <kjlu@....edu>, smccaman@....edu
Subject: Re: [PATCH] gpio: rcar: handle pm_runtime_get_sync failure case

On Fri, Jun 5, 2020 at 4:49 AM Navid Emamdoost
<navid.emamdoost@...il.com> wrote:

> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> ---
>  drivers/gpio/gpio-rcar.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 7284473c9fe3..eac1582c70da 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset)
>         int error;
>
>         error = pm_runtime_get_sync(p->dev);
> -       if (error < 0)
> +       if (error < 0) {
> +               pm_runtime_put(p->dev);
>                 return error;
> +       }

I need Geert's review on this, he's usually on top of the Renesas stuff.

Yours,
Linus Walleij