linux-kernel - Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200610100155.GB5005@sirena.org.uk>
Date:   Wed, 10 Jun 2020 11:01:56 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Pi-Hsun Shih <pihsun@...omium.org>
Cc:     Nicolas Boichat <drinkcat@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Fabien Lahoudere <fabien.lahoudere@...labora.com>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

On Wed, Jun 10, 2020 at 12:31:53PM +0800, Pi-Hsun Shih wrote:
> On Tue, Jun 9, 2020 at 7:19 PM Mark Brown <broonie@...nel.org> wrote:
> > On Tue, Jun 09, 2020 at 03:59:55PM +0800, Pi-Hsun Shih wrote:

> > > +     int min_mV = DIV_ROUND_UP(min_uV, 1000);
> > > +     int max_mV = max_uV / 1000;
> > > +     struct ec_params_regulator_set_voltage cmd = {
> > > +             .index = data->index,
> > > +             .min_mv = min_mV,
> > > +             .max_mv = max_mV,
> > > +     };
> > > +
> > > +     if (min_mV > max_mV)
> > > +             return -EINVAL;

> > The core will do this for you.

> Since I'm doing DIV_ROUND_UP for the min_mV, so this may happen if the
> min_uV~max_uV range given by the core doesn't contain any value that
> can be represented exactly in mV.

This isn't clear from the code - I'd add a comment or move the division
to be next to the check.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)