linux-kernel - Re: [PATCH] videobuf2: always re-init queue memory consistency attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200610104853.GB271650@jagdpanzerIV.localdomain>
Date:   Wed, 10 Jun 2020 19:48:53 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Tomasz Figa <tfiga@...omium.org>
Cc:     Hans Verkuil <hverkuil@...all.nl>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] videobuf2: always re-init queue memory consistency
 attribute

On (20/06/10 12:17), Tomasz Figa wrote:
[..]
> > Is it OK with you if I fold this patch into the original patch series and make a
> > new PR for it? I prefer to have a series merged without a bug, rather than fixing
> > it in a final patch.
> 
> I believe this didn't introduce any real bug, because dma_attrs would
> end up used only for MMAP buffers anyway. Still, the current behavior
> could end up being confusing for whoever has to deal with vb2 in the
> future, so should be fixed.

This also requires user-space code that constantly use different ->memory
types and ->flags in inoctl()-s on the same queue.

	-ss