linux-kernel - Re: [PATCH] powerpc/pseries/svm: Fixup align argument in alloc_shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87imfzf9o2.fsf@mpe.ellerman.id.au>
Date:   Wed, 10 Jun 2020 21:21:49 +1000
From:   Michael Ellerman <michaele@....ibm.com>
To:     Satheesh Rajendran <sathnaga@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Cc:     Satheesh Rajendran <sathnaga@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
        Ram Pai <linuxram@...ibm.com>,
        Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
        Laurent Dufour <ldufour@...ux.ibm.com>
Subject: Re: [PATCH] powerpc/pseries/svm: Fixup align argument in alloc_shared_lppaca() function

Satheesh Rajendran <sathnaga@...ux.vnet.ibm.com> writes:
> Argument "align" in alloc_shared_lppaca() function was unused inside the
> function. Let's fix it and update code comment.

I think it would be better to drop the align argument entirely and keep
that logic, and the comment, internal to alloc_shared_lppaca().

cheers