lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Jun 2020 13:26:59 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Serge Semin <fancer.lancer@...il.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Lee Jones <lee.jones@...aro.org> Subject: Re: [PATCH v1 2/6] gpio: dwapb: Read GPIO base from snps,gpio-base property On Mon, Jun 8, 2020 at 3:43 PM Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote: > For backward compatibility with some legacy devices, introduce > a new property snps,gpio-base to read GPIO base. Don't advertise > to discourage users from utilizing it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> I usually have a very negative gut reaction to any attempts to hardcode the heavily deprecated use of the gpio_base for the global GPIO numberspace. The reason is clear from drivers/gpio/TODO I think. I need a really good explanation why this is needed, the only reason people have been pushing this in the past is "oh we are using the sysfs and we don't wanna change the GPIO numbers in our scripts" which I really want to push back on now that we have the chardev and the libgpiod utils. If this is needed for something driver internal, it should stay in a driver-local variable. Yours, Linus Walleij
Powered by blists - more mailing lists