linux-kernel - Re: [PATCH] cxlflash: remove an unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159175452258.16072.8552277193377320754.b4-ty@oracle.com>
Date:   Tue,  9 Jun 2020 22:02:44 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "Manoj N. Kumar" <manoj@...ux.ibm.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        kernel-janitors@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, Uma Krishnan <ukrishn@...ux.ibm.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] cxlflash: remove an unnecessary NULL check

On Fri, 5 Jun 2020 14:02:58 +0300, Dan Carpenter wrote:

> The "cmd" pointer was already dereferenced a couple lines earlier so
> this NULL check is too late.  Fortunately, the pointer can never be NULL
> and the check can be removed.

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: cxlflash: Remove an unnecessary NULL check
      https://git.kernel.org/mkp/scsi/c/89dd9ce784fb

-- 
Martin K. Petersen	Oracle Linux Engineering