lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Jun 2020 15:18:52 +0300 From: Luciano Coelho <luciano.coelho@...el.com> To: Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org, Johannes Berg <johannes.berg@...el.com>, Emmanuel Grumbach <emmanuel.grumbach@...el.com>, Intel Linux Wireless <linuxwifi@...el.com>, Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Sara Sharon <sara.sharon@...el.com> Cc: Andrei Otcheretianski <andrei.otcheretianski@...el.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 02/15] iwlwifi: mvm: fix gcc-10 zero-length-bounds warning On Thu, 2020-04-30 at 23:30 +0200, Arnd Bergmann wrote: > gcc-10 complains when a zero-length array is accessed: > > drivers/net/wireless/intel/iwlwifi/mvm/tx.c: In function 'iwl_mvm_rx_ba_notif': > drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1929:17: warning: array subscript 9 is outside the bounds of an interior zero-length array 'struct iwl_mvm_compressed_ba_tfd[0]' [-Wzero-length-bounds] > 1929 | &ba_res->tfd[i]; > | ~~~~~~~~~~~^~~ > In file included from drivers/net/wireless/intel/iwlwifi/mvm/../fw/api/tdls.h:68, > from drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h:68, > from drivers/net/wireless/intel/iwlwifi/mvm/sta.h:73, > from drivers/net/wireless/intel/iwlwifi/mvm/mvm.h:83, > from drivers/net/wireless/intel/iwlwifi/mvm/tx.c:72: > drivers/net/wireless/intel/iwlwifi/mvm/../fw/api/tx.h:769:35: note: while referencing 'tfd' > 769 | struct iwl_mvm_compressed_ba_tfd tfd[0]; > | ^~~ > > Change this structure to use a flexible-array member for 'tfd' instead, > along with the various structures using an zero-length ieee80211_hdr > array that do not show warnings today but might be affected by similar > issues in the future. > > Fixes: 6f68cc367ab6 ("iwlwifi: api: annotate compressed BA notif array sizes") > Fixes: c46e7724bfe9 ("iwlwifi: mvm: support new BA notification response") > Signed-off-by: Arnd Bergmann <arnd@...db.de> Patch applied to iwlwifi-next.git, thanks. 9cec1d547cb7 iwlwifi: mvm: fix gcc-10 zero-length-bounds warning
Powered by blists - more mailing lists