linux-kernel - Re: [PATCH v1 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ed87ef0-170d-4543-5d90-8c8b223c704c@linux.intel.com>
Date:   Wed, 10 Jun 2020 10:11:42 +0800
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org, balbi@...nel.org
Cc:     gregkh@...uxfoundation.org, robh@...nel.org,
        devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com, yin1.li@...el.com,
        andriy.shevchenko@...el.com
Subject: Re: [PATCH v1 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC

Hi Philipp,

    Thanks for the review comments...

On 9/6/2020 8:14 pm, Philipp Zabel wrote:
>> +
>> +	for (i = 0; i < ARRAY_SIZE(CTL_RESETS); i++)
>> +		reset_control_deassert(resets[i]);
>> +	/* Need to wait at least 20us before de-assert the PHY */
>> +	usleep_range(20, 100);
> This waits 20us after de-asserting the reset, not before. Is this in the
> correct place?
This is correct place , but the above mentioned comments are wrong, need 
to re-write the comments as below...

/* out-of-band reset of the controller after PHY reset
  * will cause controller malfunctioning, so should use in-bandcontroller
  * reset only and leave the controller de-asserted here.
  */
     for (i = 0; i < ARRAY_SIZE(CTL_RESETS); i++)
             reset_control_deassert(resets[i]);

/* Need to wait at least 20us after de-assert the PHY */
     usleep_range(20, 100);


Regards
Vadivel

>