[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200610132402.GB26639@lenoir>
Date: Wed, 10 Jun 2020 15:24:03 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: tglx@...utronix.de, linux-kernel@...r.kernel.org, x86@...nel.org,
cai@....pw, mgorman@...hsingularity.net, sfr@...b.auug.org.au,
linux@...ck-us.net
Subject: Re: [RFC][PATCH 5/7] irq_work, smp: Allow irq_work on
call_single_queue
On Fri, Jun 05, 2020 at 11:37:04AM +0200, Peter Zijlstra wrote:
> On Fri, May 29, 2020 at 03:36:41PM +0200, Peter Zijlstra wrote:
> > Maybe I can anonymous-union my way around it, dunno. I'll think about
> > it. I'm certainly not proud of this. But at least the BUILD_BUG_ON()s
> > should catch the more blatant breakage here.
>
> How's this then? Differently ugly, but at least it compiles with that
> horrible struct randomization junk enabled.
>
> ---
> include/linux/irq_work.h | 28 ++++++-------------
> include/linux/sched.h | 4 +-
> include/linux/smp.h | 25 ++++++-----------
> include/linux/smp_types.h | 66 ++++++++++++++++++++++++++++++++++++++++++++++
> kernel/sched/core.c | 6 ++--
> kernel/smp.c | 18 ------------
> 6 files changed, 89 insertions(+), 58 deletions(-)
Looks good. I don't have a better idea.
Thanks!
Reviewed-by: Frederic Weisbecker <frederic@...nel.org>
Powered by blists - more mailing lists