linux-kernel - Re: [PATCH] sysctl: Delete the code of sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84286450-295b-b61b-f400-f08e7eafbe7c@huawei.com>
Date:   Wed, 10 Jun 2020 22:19:26 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
CC:     <keescook@...omium.org>, <ak@...ux.intel.com>,
        <alex.huangjianhui@...wei.com>, <linzichang@...wei.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysctl: Delete the code of sys_sysctl

On 2020/6/10 3:20, Eric W. Biederman wrote:
> Xiaoming Ni <nixiaoming@...wei.com> writes:
> 
>> Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"),
>> sys_sysctl has lost its actual role: any input can only return an error.
> 
> The remaining code does have a role.  It reports programs that attempt
> to use the removed sysctl.
> 
> It would help if your change description had a reason why we don't want
> to warn people that a program has used a removed system call.
> 
> Probably something like:
> 
>    We have been warning about people using the sysctl system call for years
>    and believe there are no more users.  Even if there are users of this
>    interface if they have not complained or fixed their code by now they
>    probably are not going to, so there is no point in warning them any
>    longer.
> 
> With a change like that made to the patch description.
> 
> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> 
Thanks for your guidance
I will add it in the v2 version

Thanks
Xiaoming Ni