linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200610145453.GC2102023@kroah.com>
Date:   Wed, 10 Jun 2020 16:54:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        Balakrishna Godavarthi <bgodavar@...eaurora.org>,
        hemantg@...eaurora.org, Johan Hedberg <johan.hedberg@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rocky Liao <rjliao@...eaurora.org>,
        Rob Herring <robh@...nel.org>,
        Sean Paul <seanpaul@...omium.org>,
        Claire Chang <tientzu@...omium.org>, yshavit@...gle.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout

On Thu, Jun 04, 2020 at 08:24:34PM +0200, Markus Elfring wrote:
> > Due to race conditions between qca_hw_error and qca_controller_memdump
> > during SSR timeout,the same pointer is freed twice.
> 
> This is an unfortunate software situation.
> 
> 
> > Which results to double free error.
> 
> How do you think about to omit this sentence from the change description?
> 
> 
> > Now a lock is acquired while SSR state moved to timeout.
> 
> I suggest to convert this information into an imperative wording.
> 
> Would you like to add the tag “Fixes” to the commit message?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot