linux-kernel - Re: [PATCH v2 0/3] serial: core: fix up sysrq regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200610162134.GL2428291@smile.fi.intel.com>
Date:   Wed, 10 Jun 2020 19:21:34 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] serial: core: fix up sysrq regressions

On Wed, Jun 10, 2020 at 05:22:29PM +0200, Johan Hovold wrote:
> This series fixes a few regressions introduced by the recent sysrq
> rework that went into 5.6.
> 
> The fix for the unnecessary per-character overhead probably could have
> been marked for stable but I left that decision to the maintainers as it
> is a bit intrusive (although mostly shuffling code around).

I see a problem, thanks for pointing out!
The fix LGTM! FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> 
> Johan
> 
> Changes in v2
>  - inline uart_unlock_and_check_sysrq() along with the other helpers
>    (restoring the interrupt state in a helper was never an issue)
> 
> 
> Johan Hovold (3):
>   Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"
>   serial: core: fix sysrq overhead regression
>   serial: core: drop redundant sysrq checks
> 
>  drivers/tty/serial/serial_core.c |  96 +----------------------------
>  include/linux/serial_core.h      | 102 +++++++++++++++++++++++++++++--
>  2 files changed, 100 insertions(+), 98 deletions(-)
> 
> -- 
> 2.26.2
> 

-- 
With Best Regards,
Andy Shevchenko