linux-kernel - Re: [PATCH] drm/ast: fix missing break in switch statement for format->cpp[0] case 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3286283e-f202-a515-0ae1-89c0d3e855fb@suse.de>
Date:   Wed, 10 Jun 2020 19:14:57 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Colin King <colin.king@...onical.com>,
        Dave Airlie <airlied@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Gerd Hoffmann <kraxel@...hat.com>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/ast: fix missing break in switch statement for
 format->cpp[0] case 4

Hi

Am 10.06.20 um 13:58 schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the switch statement for format->cpp[0] value 4 assigns
> color_index which is never read again and then falls through to the
> default case and returns. This looks like a missing break statement
> bug. Fix this by adding a break statement.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: 259d14a76a27 ("drm/ast: Split ast_set_vbios_mode_info()")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Thanks for the fix. I'll test and merge the patch tomorrow.

Best regards
Thomas

> ---
>  drivers/gpu/drm/ast/ast_mode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 7d39b858c9f1..3a3a511670c9 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -226,6 +226,7 @@ static void ast_set_vbios_color_reg(struct ast_private *ast,
>  	case 3:
>  	case 4:
>  		color_index = TrueCModeIndex;
> +		break;
>  	default:
>  		return;
>  	}
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)