linux-kernel - [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jun 2020 13:46:25 -0600
From:   Rob Herring <robh@...nel.org>
To:     devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Lee Jones <lee.jones@...aro.org>,
        Maxime Ripard <maxime@...no.tech>
Subject: [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible

Using 'syscon' alone should be avoided as compatible strings should be
specific enough to identify the exact set of registers contained. Update
the schema to ensure at least 2 compatible strings are present.

Cc: Lee Jones <lee.jones@...aro.org>
Cc: Maxime Ripard <maxime@...no.tech>
Signed-off-by: Rob Herring <robh@...nel.org>
---
FYI, there's 43 cases of this on arm32 in my testing.

 Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 19bdaf781853..af7a68051392 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -43,7 +43,8 @@ properties:
 
       - contains:
           const: syscon
-        additionalItems: true
+        minItems: 2
+        maxItems: 4  # Should be enough
 
   reg:
     maxItems: 1
-- 
2.25.1