linux-kernel - Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200611224355.71174-1-ndesaulniers@google.com>
Date:   Thu, 11 Jun 2020 15:43:55 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     patch-notifications@...erman.id.au, christophe.leroy@....fr,
        segher@...nel.crashing.org
Cc:     benh@...nel.crashing.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, npiggin@...il.com, paulus@...ba.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using
 'asm goto'

Hello! It seems this patch broke our ppc32 builds, and we had to
disable them [0]. :(

>From what I can tell, though Michael mentioned this was merged on May
29, but our CI of -next was green for ppc32 until June 4, then mainline
went red June 6. So this patch only got 2 days of soak time before the
merge window opened.

A general issue with the -next workflow seems to be that patches get
different amounts of soak time. For higher risk patches like this one,
can I please ask that they be help back a release if close to the merge
window?

Segher, Cristophe, I suspect Clang is missing support for the %L and %U
output templates [1]. I've implemented support for some of these before
in Clang via the documentation at [2], but these seem to be machine
specific? Can you please point me to documentation/unit tests/source for
these so that I can figure out what they should be doing, and look into
implementing them in Clang?

[0] https://github.com/ClangBuiltLinux/continuous-integration/pull/279
[1] https://bugs.llvm.org/show_bug.cgi?id=46186
[2]
https://gcc.gnu.org/onlinedocs/gccint/Output-Template.html#Output-Template