linux-kernel - Re: [PATCH v13 5/9] nvme-core: Introduce nvme_ctrl_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965AE69900A7832EEC4141086800@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Thu, 11 Jun 2020 23:02:40 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Logan Gunthorpe <logang@...tatee.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>
CC:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Max Gurtovoy <maxg@...lanox.com>,
        Stephen Bates <sbates@...thlin.com>
Subject: Re: [PATCH v13 5/9] nvme-core: Introduce nvme_ctrl_get_by_path()

On 5/14/20 10:23 AM, Logan Gunthorpe wrote:
> +#ifdef CONFIG_NVME_TARGET_PASSTHRU
> +/*
> + * The exports that follow within this ifdef are only for
> + * use by the nvmet-passthru and should not be used for
> + * other things.
> + */

The above comment is duplicate #ifdef is self explanatory and I didn't
find similar style in existing repo  (e.g. CONFIG_NVME_MULTIPATH,
CONFIG_BLK_SED_OPAL) so let's not introduce new style which will create
confusion to future code.