linux-kernel - Re: [PATCH V2 1/2] mtd: rawnand: qcom: remove write to unavailable register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a82ed80-0ca3-ecb6-2c30-7ac279d437fa@codeaurora.org>
Date:   Thu, 11 Jun 2020 10:00:00 +0530
From:   Sivaprakash Murugesan <sivaprak@...eaurora.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     richard@....at, vigneshr@...com, peter.ujfalusi@...com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] mtd: rawnand: qcom: remove write to unavailable
 register

Hi Miquel,

On 6/9/2020 7:32 PM, Miquel Raynal wrote:
> Hi Sivaprakash,
>
> Sivaprakash Murugesan <sivaprak@...eaurora.org> wrote on Tue,  9 Jun
> 2020 16:40:55 +0530:
>
>> SFLASHC_BURST_CFG register is not available on all ipq nand platforms,
>> it is available only on ipq8064 devices and the nand controller works
>> without configuring these registers in this platform, so register write
>> to this can be removed.
> Maybe it works because the bootloader is setting the register itself.
> What if you use a different bootloader, or the same bootloader without
> NAND support?
>
> I don't think this is a proper fix, you should instead have a different
> compatible if the IP is not the same and depending on this compatible
> do the write, or not.

I understand your point, will fix this in next patch.

Thanks,

Siva

> Thanks,
> Miquèl