linux-kernel - Re: [PATCH] Replace HTTP links with HTTPS ones: Documentation/translations/it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ee16c38-e28b-b4e6-ed30-55a59e216b49@al2klimov.de>
Date:   Thu, 11 Jun 2020 09:01:27 +0200
From:   "Alexander A. Klimov" <grandmaster@...klimov.de>
To:     Kees Cook <keescook@...omium.org>
Cc:     Federico Vaga <federico.vaga@...a.pv.it>,
        Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        David Sterba <dsterba@...e.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Theodore Ts'o <tytso@....edu>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>,
        Jacob Huisman <jacobhuisman@...nelthusiast.com>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Rob Herring <robh@...nel.org>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones:
 Documentation/translations/it_IT



Am 11.06.20 um 05:12 schrieb Kees Cook:
> On Wed, Jun 10, 2020 at 08:11:39PM +0200, Alexander A. Klimov wrote:
>> Am 10.06.20 um 10:57 schrieb Federico Vaga:
>>> On Tuesday, June 9, 2020 10:12:41 PM CEST Alexander A. Klimov wrote:
>>>> Rationale:
>>>> Reduces attack surface on kernel devs opening the links for MITM
>>>> as HTTPS traffic is much harder to manipulate.
>>>>
>>>> Deterministic algorithm:
>>>> For each file:
>>>>     For each line:
>>>>       If doesn't contain `\bxmlns\b`:
>>>>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>>>>           If both the HTTP and HTTPS versions
>>>>           return 200 OK and serve the same content:
>>>>             Replace HTTP with HTTPS.
> 
> Is this script somewhere we can read it? (It's easier usually to review
> the code for bulk changes than the bulk changes themselves.)
Is any of you familiar with Golang?

@Maintainers Would any of you actually review like this? If yes, is the 
pseudo-code not enough?

> 
>>>>
>>>> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
>>>> ---
>>>>    .../translations/it_IT/admin-guide/README.rst      |  2 +-
>>>>    .../translations/it_IT/doc-guide/parse-headers.rst |  2 +-
>>>>    .../translations/it_IT/doc-guide/sphinx.rst        | 10 +++++-----
>>>>    .../translations/it_IT/process/2.Process.rst       | 12 ++++++------
>>>>    .../translations/it_IT/process/3.Early-stage.rst   |  2 +-
>>>>    .../translations/it_IT/process/4.Coding.rst        |  4 ++--
>>>>    .../it_IT/process/7.AdvancedTopics.rst             |  8 ++++----
>>>>    .../translations/it_IT/process/8.Conclusion.rst    | 14 +++++++-------
>>>>    .../translations/it_IT/process/adding-syscalls.rst |  4 ++--
>>>>    .../translations/it_IT/process/changes.rst         |  6 +++---
>>>>    .../translations/it_IT/process/clang-format.rst    |  2 +-
>>>>    .../translations/it_IT/process/coding-style.rst    |  2 +-
>>>>    Documentation/translations/it_IT/process/howto.rst |  2 +-
>>>>    .../it_IT/process/maintainer-pgp-guide.rst         |  2 +-
>>>>    .../it_IT/process/submitting-patches.rst           |  4 ++--
>>>>    .../it_IT/process/volatile-considered-harmful.rst  |  4 ++--
>>>>    16 files changed, 40 insertions(+), 40 deletions(-)
>>>>
>>>
>>>
>>>> diff --git a/Documentation/translations/it_IT/doc-guide/sphinx.rst
>>>> b/Documentation/translations/it_IT/doc-guide/sphinx.rst index
>>>> f1ad4504b734..0aaeb0297661 100644
>>>> --- a/Documentation/translations/it_IT/doc-guide/sphinx.rst
>>>> +++ b/Documentation/translations/it_IT/doc-guide/sphinx.rst
>>>> @@ -14,7 +14,7 @@ Per generare la documentazione in HTML o PDF, usate
>>>> comandi ``make htmldocs`` o ``make pdfdocs``. La documentazione così
>>>> generata sarà disponibile nella cartella ``Documentation/output``.
>>>>
>>>> -.. _Sphinx: http://www.sphinx-doc.org/
>>>> +.. _Sphinx: https://www.sphinx-doc.org/
>>>>    .. _reStructuredText: http://docutils.sourceforge.net/rst.html
>>>
>>> It is not part of the deterministic algorithm but you may consider this as
>>> well
> 
> Why did it not match?
I didn't log that link-by-link. Maybe because I also didn't follow plain 
HTTP redirects while opening HTTPS links. Maybe it even matched, but was 
added after I made the changes.

Anyway, I'll maybe cover it in round II.

> 
>>>
>>> -.. _reStructuredText: http://docutils.sourceforge.net/rst.html
>>> +.. _reStructuredText: https://docutils.sourceforge.io/rst.html
>>>
>> I'll think about analyzing such almost-matches, extending the algo and
>> supplying a second round of patches once all [1] of this round arrive in
>> torvalds/master.
>>
>> [1]:
>>
>> ➜  linux git:(feature/https-links-3) ✗ git diff --shortstat
>>   1963 files changed, 2882 insertions(+), 2882 deletions(-)
>> ➜  linux git:(feature/https-links-3) ✗
> 
> Is there a reason to do this one language at a time instead of just
> doing everything in one go?
There are two reasons:

* Jonathan said like theoretically you could give it all at once to 
Linus, but practically I'd not do that, please split by subsystem
* Linus *didn't even respond* (at least I didn't receive anything) to my 
catch-them-all patch at all, not even like please not as .gz attachment 
or please split by subsystem

>