linux-kernel - Re: [PATCH v3 2/2] regulator: Add driver for cros-ec-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANdKZ0cwcTaXM+y3scooJyrH_DVdF8=jS2QN96CyoPrH8RmbTg@mail.gmail.com>
Date:   Thu, 11 Jun 2020 15:20:42 +0800
From:   Pi-Hsun Shih <pihsun@...omium.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Nicolas Boichat <drinkcat@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Lee Jones <lee.jones@...aro.org>,
        Yicheng Li <yichengli@...omium.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] regulator: Add driver for cros-ec-regulator

Thanks for the review, would address most of them in v4. An inline
reply as below:

On Thu, Jun 11, 2020 at 12:47 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> Hi Pi-Hsun,
>
> Thank you for your patch.
>
> On 10/6/20 11:07, Pi-Hsun Shih wrote:
> > +/*****************************************************************************/
> > +/* Voltage regulator controls */
> > +
> > +/*
> > + * Get basic info of voltage regulator for given index.
> > + *
> > + * Returns the regulator name and supported voltage list in mV.
> > + */
> > +#define EC_CMD_REGULATOR_GET_INFO 0x012B
>
> This introduces a new EC command, while you are here, please also add the
> command in drivers/platform/chrome/cros_ec_trace.c, so we can trace properly the
> command. Also can you point me to the commit that introduces this command in the
> EC firmware?

The commit that introduces this in EC firmware is at https://crrev.com/c/2100327