lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Jun 2020 09:31:57 +0200 From: Maxime Ripard <maxime@...no.tech> To: Nicolas Saenz Julienne <nsaenzjulienne@...e.de> Cc: linux-rpi-kernel@...ts.infradead.org, bcm-kernel-feedback-list@...adcom.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Dave Stevenson <dave.stevenson@...pberrypi.com>, Tim Gover <tim.gover@...pberrypi.com>, Phil Elwell <phil@...pberrypi.com>, Mike Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org, Maxime Ripard <maxime@...no.tech> Subject: [PATCH v4 08/27] clk: bcm: rpi: Make sure pllb_arm is removed The pllb_arm clock was created at probe time, but was never removed if something went wrong later in probe, or if the driver was ever removed from the system. Now that we are using clk_hw_register(), we can just use its managed variant to take care of that for us. Cc: Michael Turquette <mturquette@...libre.com> Cc: Stephen Boyd <sboyd@...nel.org> Cc: linux-clk@...r.kernel.org Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de> Reviewed-by: Stephen Boyd <sboyd@...nel.org> Signed-off-by: Maxime Ripard <maxime@...no.tech> --- drivers/clk/bcm/clk-raspberrypi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index b21dd6ddc4fe..d62605861028 100644 --- a/drivers/clk/bcm/clk-raspberrypi.c +++ b/drivers/clk/bcm/clk-raspberrypi.c @@ -240,7 +240,7 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi) { int ret; - ret = clk_hw_register(rpi->dev, &raspberrypi_clk_pllb_arm.hw); + ret = devm_clk_hw_register(rpi->dev, &raspberrypi_clk_pllb_arm.hw); if (ret) { dev_err(rpi->dev, "Failed to initialize pllb_arm\n"); return ret; @@ -250,7 +250,6 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi) NULL, "cpu0"); if (!rpi->pllb_arm_lookup) { dev_err(rpi->dev, "Failed to initialize pllb_arm_lookup\n"); - clk_hw_unregister_fixed_factor(&raspberrypi_clk_pllb_arm.hw); return -ENOMEM; } -- git-series 0.9.1
Powered by blists - more mailing lists