linux-kernel - Re: [PATCH v2] exfat: add missing brelse() calls on error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e64100a-b623-a4d2-c5d0-cc9235669cdf@web.de>
Date:   Thu, 11 Jun 2020 10:00:55 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Namjae Jeon <namjae.jeon@...sung.com>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        linux-fsdevel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Tetsuhiro Kohada <kohada.t2@...il.com>,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH v2] exfat: add missing brelse() calls on error paths

…
> +++ b/fs/exfat/namei.c
> @@ -1077,10 +1077,14 @@ static int exfat_rename_file(struct inode *inode, struct exfat_chain *p_dir,
>
>  		epold = exfat_get_dentry(sb, p_dir, oldentry + 1, &old_bh,
>  			&sector_old);
> +		if (!epold)
> +			return -EIO;
…

Can it become helpful to annotate such null pointer checks for branch prediction?
Would you like to indicate a likelihood in any way?

Regards,
Markus