linux-kernel - Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jun 2020 14:09:54 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

Hi Mark,

On Thu, Jun 11, 2020 at 10:50 AM Mark Brown <broonie@...nel.org> wrote:
> On Wed, Jun 10, 2020 at 09:18:19PM +0200, Geert Uytterhoeven wrote:
> > On Wed, Jun 10, 2020 at 6:49 PM Mark Brown <broonie@...nel.org> wrote:
>
> > > I'm much more comfortable explicitly listing the new compatible so that
> > > even if someone makes a DT that doesn't bother listing the fallbacks
> > > things will work.
>
> > Adding all of them would cause even more churn when adding support for
> > a new SoC... There are already more than 700 "renesas," compatible
> > values documented that are not directly matched by drivers.
>
> I'm not sure it's a particular concern, especially since you'll be
> sending this stuff in the same series as a bindings update and an extra
> patch in a series makes very little difference.

Until the DT bindings are split off into their own project...

Listing unneeded compatible values in drivers also increases binary size.
For RSPI and MSIOF that would be +2.5 KiB each.  Times tens of drivers.

Considering the RSPI driver itself is only 9 KiB, and some RZ/A1 systems
are really memory-constrained, I think it's better to avoid that.

> > Nowadays we have "make dtbs_check", so if a DTS doesn't conform to the
> > binding, it will be flagged.
>
> For things that are upstream.

The DT bindings apply to out-of-tree DTS files, too ;-)
If they're not compliant, all odds are off.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds