linux-kernel - Re: linux-next: manual merge of the scsi-mkp tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Jun 2020 12:12:40 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     James Bottomley <James.Bottomley@...senPartnership.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Simon Arlott <simon@...iron.net>,
        Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>
Subject: Re: linux-next: manual merge of the scsi-mkp tree with Linus' tree

Hi all,

On Wed, 10 Jun 2020 12:17:07 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Today's linux-next merge of the scsi-mkp tree got a conflict in:
> 
>   drivers/scsi/sr.c
> 
> between commit:
> 
>   a711d91cd97e ("block: add a cdrom_device_info pointer to struct gendisk")
> 
> from Linus' tree and commit:
> 
>   6555781b3fde ("scsi: sr: Fix sr_probe() missing deallocate of device minor")
> 
> from the scsi-mkp tree.
> 

> diff --cc drivers/scsi/sr.c
> index 4dcd735ea49e,b9cff27e2c81..000000000000
> --- a/drivers/scsi/sr.c
> +++ b/drivers/scsi/sr.c
> @@@ -790,9 -790,10 +790,9 @@@ static int sr_probe(struct device *dev
>   	set_capacity(disk, cd->capacity);
>   	disk->private_data = &cd->driver;
>   	disk->queue = sdev->request_queue;
>  -	cd->cdi.disk = disk;
>   
>  -	if (register_cdrom(&cd->cdi))
>  +	if (register_cdrom(disk, &cd->cdi))
> - 		goto fail_put;
> + 		goto fail_minor;
>   
>   	/*
>   	 * Initialize block layer runtime PM stuffs before the

This is now a conflict between the scsi tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped